slacknetsetup, branch current-20171128

rc.inet1: Fix typo ( $1 --> $i )

2017-11-27T05:09:14+00:00

Signed-off-by: Robby Workman

netconfig: Add back a dropped "."

2017-11-26T20:38:41+00:00

rc.inet1: Check for iface in /sys/class/net, not /proc/net/dev

2017-11-21T06:07:59+00:00

There is a slight problem with things like
  grep lo: /proc/net/dev
especially with tun/tap devices with can have arbitrary names.

Consider a scenario where you name your tap iface "trololo":
$ grep -c lo: /proc/net/dev
2
$

To fix this (quite hypothetical, but still) problem, instead
of simple grepping in /proc/net/dev, check of sysfs path
existence (/sys/class/net/).

Same fix in if_up() and if_down() for non-loopback interfaces.

While there, also strip colon-whatever from interface name
(what I think was the original idea behind a construct like
grep $(echo ${1}: | cut -f 1 -d :): /proc/net/dev) by using
parameter expansion: ${1%%:*} will remove the longest suffix
matching ":*", ie. colon-and-everything-after.
This is supported by POSIX:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html

Alternative solution would be to change the grep pattern to
  grep '^ *lo:' /proc/net/dev

Signed-off-by: Robby Workman

rc.inet1: Remove unnecessary unset num

2017-11-21T06:07:59+00:00

The only places using "num" already clear it with "num=0"

Signed-off-by: Robby Workman

netconfig: Add comment to netconfig-generated rc.inet1.conf

2017-11-21T06:07:59+00:00

Add same comment as in 4561bd10747935edf3e4f17ad18768d17ee95a4e

Signed-off-by: Robby Workman

rc.inet1: Factor DEBUG_ETH_UP logging to a separate function

2017-11-21T06:07:59+00:00

Signed-off-by: Robby Workman

rc.inet1: Use ${array[*]} not ${array[@]} to produce a string

2017-11-21T06:07:59+00:00

This is the correct usage to produce one string from all
elements of an array.

foo[0]=b
foo[1]=a
foo[2]=r

"${foo[@]}" here would mean "b" "a" "r"
"${foo[*]}" however: "b a r", and that's what we mean when
logging it.

Signed-off-by: Robby Workman

rc.inet1: Avoid de-/configuring ifaces with indexes >=MAXNICS

2017-11-21T06:07:59+00:00

The code around MAXNICS currently only uses it to populate
first $MAXNICS elements of IFNAME array, which is later
used to match interface name to index used to access all
other arrays.

If you configure IPADDR[6], this code doesn't find a matching
entry in IFNAME but doesn't do anything about it. This works
by accident, because iteration variable "i" stays at "6" after
exiting the loop.

But when you configure IPADDR[7], it will still stay on "6",
and will use ...[6] values to configure that interface, which
is potentially damaging.

Better safe than sorry: let's check for this overflow and do
nothing, instead of potentially doing the wrong thing.

Signed-off-by: Robby Workman

rc.inet1: Avoid code duplication by combining case/esac

2017-11-21T06:07:59+00:00

There's no reason to have separate cases for

 start) ... ;;
 up) ... ;;

if they both have the same bodies. Let's combine such cases to avoid
code duplication.

Also, this is that one time where quoting isn't really needed :)

Signed-off-by: Robby Workman

rc.inet1: Add missing 'dev' keyword

2017-11-21T06:07:59+00:00

Also, replace "ip addr" with "ip address" for consistency

Signed-off-by: Robby Workman